Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: visual tests: Add more ignore regions for dashboard component #42786

Merged
merged 1 commit into from
Aug 17, 2021
Merged

mgr/dashboard: visual tests: Add more ignore regions for dashboard component #42786

merged 1 commit into from
Aug 17, 2021

Conversation

aaryanporwal
Copy link
Contributor

@aaryanporwal aaryanporwal commented Aug 16, 2021 •
edited

Fixes: https://tracker.ceph.com/issues/52282

This PR adds ignore regions to all the dynamic content on the dynamic landing page, rather than just the charts.

A lot of prs like this have reported false positives due to changing text on the landing page or the 6px top padding on the charts. This pr will mitigate all the false positives that we've seen up till now.

Regions with card-text class.

Signed-off-by: Aaryan Porwal aaryanporwal2233@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@aaryanporwal aaryanporwal requested a review from a team as a code owner August 16, 2021 09:41
@aaryanporwal aaryanporwal requested review from pereman2, Waadkh7 and cypherean and removed request for a team August 16, 2021 09:41
@aaryanporwal aaryanporwal added this to In progress in Dashboard via automation Aug 16, 2021
@tchaikov tchaikov added the tests label Aug 16, 2021
@aaryanporwal aaryanporwal marked this pull request as draft August 16, 2021 09:43
@alfonsomthd alfonsomthd added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Aug 16, 2021
nizamial09
nizamial09 reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aaryanporwal Can you add the tracker to the commit and description of PR? Also, is there anything left to be done here apart from these changes?

@aaryanporwal
Copy link
Contributor Author

Hey @aaryanporwal Can you add the tracker to the commit and description of PR? Also, is there anything left to be done here apart from these changes?

There isn't any issue filed for this on the tracker, should I open one and mention it in the PR? Also yeah, I'm testing another better css selector right now, hence the draft pr.

@nizamial09
Copy link
Member

should I open one and mention it in the PR?

Yes, that would be great.

I'm testing another better css selector right now,

Thank you, Let us know when it is done.

@aaryanporwal
mgr/dashboard: visual tests: Add more ignore regions for dashboard co…
dfdfbe5 
…mponent

Fixes: https://tracker.ceph.com/issues/52282

Signed-off-by: Aaryan Porwal <aaryanporwal2233@gmail.com>
@aaryanporwal aaryanporwal marked this pull request as ready for review August 16, 2021 10:36
@aaryanporwal
Copy link
Contributor Author

should I open one and mention it in the PR?

Yes, that would be great.

I'm testing another better css selector right now,

Thank you, Let us know when it is done.

I've added the tracker in commit and description of pr and have made the necessary changes in my commit as well. It's now ready for review.

@nizamial09
Copy link
Member

jenkins test dashboard

2 similar comments
@nizamial09
Copy link
Member

jenkins test dashboard

@aaryanporwal
Copy link
Contributor Author

jenkins test dashboard

@aaryanporwal
Copy link
Contributor Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member

jenkins test dashboard

Dashboard automation moved this from In progress to Reviewer approved Aug 17, 2021
@alfonsomthd alfonsomthd moved this from Reviewer approved to Ready-to-merge in Dashboard Aug 17, 2021
@alfonsomthd alfonsomthd merged commit 1ebf690 into ceph:master Aug 17, 2021
Dashboard automation moved this from Ready-to-merge to Done Aug 17, 2021
@epuertat epuertat mentioned this pull request Sep 21, 2021
Merged
@callithea callithea mentioned this pull request Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereman2 pereman2 pereman2 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@Waadkh7 Waadkh7 Awaiting requested review from Waadkh7

@cypherean cypherean Awaiting requested review from cypherean

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

@epuertat epuertat Awaiting requested review from epuertat

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

Assignees
No one assigned
Labels
dashboard pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology tests
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
5 participants
@aaryanporwal @nizamial09 @pereman2 @tchaikov @alfonsomthd