librbd/cache/pwl/ssd: fix first_valid_entry calculation in retire_entries() #42843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@MahatiC please review. |
idryomov
reviewed
Aug 19, 2021
idryomov
changed the title
majianpeng
force-pushed
the
pwl-ssd-restart-failed
branch
from
ce34436
to
b235983
Compare
MahatiC
reviewed
Aug 20, 2021
majianpeng
commented
Aug 20, 2021
majianpeng
force-pushed
the
pwl-ssd-restart-failed
branch
from
b235983
to
f00e156
Compare
|
@idryomov . please review. Thanks! |
…ries() Consider one control_block which cotain multi encode(WriteLogCacheEntry): Log1: WriteLogEntry Log2: WriteLogEntry Log3: Non-WriteLogEntry For this case, currently calc method is: control_block_pos + sizeof(control_block). But in fact, it should: control_block_pos + sizeof(control_block) + data_length(Log1 + Log2). Wrong first_valid_entry will persist to superblock and restart to read. This cause read wrong position and when decode(WriteLogCacheEntry) it will report bug. Fixes: https://tracker.ceph.com/issues/52323 Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
idryomov
force-pushed
the
pwl-ssd-restart-failed
branch
from
f00e156
to
2d337fb
Compare
|
It looked good to me but I decided to tweak it bit:
Let me know if you see any issues with that. |
majianpeng
commented
Aug 25, 2021
idryomov
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox