common/options: validate see-also #42845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideepika
requested changes
Aug 23, 2021
There was a problem hiding this comment.
shaman failure looks related,
Traceback (most recent call last):
File "/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/arm64/AVAILABLE_ARCH/arm64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-7149-g46305a89/rpm/el8/BUILD/ceph-17.0.0-7149-g46305a89/src/common/options/y2c.py", line 366, in <module>
main()
File "/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/arm64/AVAILABLE_ARCH/arm64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-7149-g46305a89/rpm/el8/BUILD/ceph-17.0.0-7149-g46305a89/src/common/options/y2c.py", line 360, in main
translate(opts)
File "/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/arm64/AVAILABLE_ARCH/arm64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-7149-g46305a89/rpm/el8/BUILD/ceph-17.0.0-7149-g46305a89/src/common/options/y2c.py", line 249, in translate
with open(opts.input) as infile, \
FileNotFoundError: [Errno 2] No such file or directory: '/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/arm64/AVAILABLE_ARCH/arm64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-7149-g46305a89/rpm/el8/BUILD/ceph-17.0.0-7149-g46305a89/aarch64-redhat-linux-gnu/src/common/options/mds-client.yaml'
https://shaman.ceph.com/builds/ceph/wip-deepika-testing-2021-08-23-1343/
|
no, the build failure is not related |
tchaikov
requested review from
avanthakkar,
aaryanporwal and
Waadkh7
and removed request for
a team
|
sorry, i was wrong. it is related. but i still don't get why. |
tchaikov
force-pushed
the
wip-51483
branch
4 times, most recently
from
9455b84
to
c08bcc1
Compare
ideepika
reviewed
Aug 23, 2021
tchaikov
commented
Aug 23, 2021
|
@ideepika could you take another look? |
|
@tchaikov make check failure is related, can you fix it: |
y2c.py is like a compiler which translates .yaml to .cc and .h files, it does not have access to all .yaml files. to validate the dangling see-also issue, we need to do this with a "linker". in this change, validate-options.py is introduced to check if any of option name included by the see-also property is valid. Fixes: https://tracker.ceph.com/issues/51483 Signed-off-by: Kefu Chai <kchai@redhat.com>
as FindPython3.cmake only sets Python3_EXECUTABLE for us, we should stick with Python3_EXECUTABLE instead of Python_EXECUTABLE. Signed-off-by: Kefu Chai <kchai@redhat.com>
@ideepika fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/51483
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox