Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: Add new flag to MClientSession #42846

Merged
merged 1 commit into from Sep 16, 2021

Conversation

kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Aug 19, 2021

The "error_string" in the metadata of MClientSession is being
parsed by kclient to validate whether the session is blocklisted.
The "error_string" is for humans and shouldn't be relied on it.
Hence added the flag to MClientsession to indicate the session
is blocklisted.

Signed-off-by: Kotresh HR khiremat@redhat.com
Fixes: Fixes: https://tracker.ceph.com/issues/52382

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the cephfs Ceph File System label Aug 19, 2021
@kotreshhr kotreshhr requested a review from batrick August 19, 2021 11:32
@kotreshhr kotreshhr marked this pull request as draft August 19, 2021 11:33
@kotreshhr
Copy link
Contributor Author

jenkins test make check

1 similar comment
@kotreshhr
Copy link
Contributor Author

jenkins test make check

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs encode/decode handlers for the new flag and a version bump on the message.

src/messages/MClientSession.h Outdated Show resolved Hide resolved
src/messages/MClientSession.h Outdated Show resolved Hide resolved
src/messages/MClientSession.h Outdated Show resolved Hide resolved
@batrick
Copy link
Member

batrick commented Aug 23, 2021

Please update tracker to: https://tracker.ceph.com/issues/52382

The "error_string" in the metadata of MClientSession is being
parsed by kclient to validate whether the session is blocklisted.
The "error_string" is for humans and shouldn't be relied on it.
Hence added the flag to MClientsession to indicate the session
is blocklisted.

Signed-off-by: Kotresh HR <khiremat@redhat.com>
Fixes: https://tracker.ceph.com/issues/52382
@kotreshhr kotreshhr marked this pull request as ready for review August 26, 2021 12:13
@kotreshhr
Copy link
Contributor Author

Please update tracker to: https://tracker.ceph.com/issues/52382

Done

batrick added a commit to batrick/ceph that referenced this pull request Sep 14, 2021
* refs/pull/42846/head:
	mds: Add new flag to MClientSession
@batrick
Copy link
Member

batrick commented Sep 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants