librbd/cache/pwl: fix m_bytes_{allocated,cached} calculation on reopen #42883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MahatiC @CongMinYin please review. Thanks |
|
retest this please |
|
LGTM |
|
@MahatiC , ping. |
|
@MahatiC ping. |
|
@MahatiC ping |
MahatiC
reviewed
Aug 25, 2021
| template <typename I> | ||
| void WriteLog<I>::calc_allocated_and_cached_data(std::shared_ptr<pwl::GenericLogEntry> log_entry, uint32_t alloc_size) { | ||
| auto gen_write_entry = static_pointer_cast<GenericWriteLogEntry>(log_entry); | ||
| if (log_entry->is_write_entry()) { |
There was a problem hiding this comment.
Could you explain why this check if (log_entry->write_bytes() == log_entry->bytes_dirty()) is removed? That check will differentiate writesame from a write request. In writesame, we don't allocate all of the write_bytes() length. I think we need to differentiate when calculating m_bytes_allocated
idryomov
reviewed
Aug 25, 2021
majianpeng
force-pushed
the
pwl-ssd-calc-allocated-bug
branch
from
8789ff6
to
d0b10b4
Compare
idryomov
reviewed
Aug 26, 2021
majianpeng
force-pushed
the
pwl-ssd-calc-allocated-bug
branch
from
d0b10b4
to
fe9e96e
Compare
|
@idryomov . update please review. |
|
I would maybe rename |
…load entries. Currently, it will load existing entries after restart and cacl m_bytes_allocated based on those entries. But currently there are the following problems： 1: The allocated of write-same is not calculated for rwl & ssd cache. 2: for ssd cache, it not include the size of log-entry itself and don't consider data alignment. This will cause less calculation and more allocatation later. And will overwrite the data which don't flush to osd and make data lost. The calculation methods of ssd and rwl are different. So add new api allocated_and_cached_data() to implement their own method. For SSD cache, we dirtly use m_first_valid_entry & m_first_free_entry to calc m_bytes_allocated. Fixes:https://tracker.ceph.com/issues/52341 Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
majianpeng
force-pushed
the
pwl-ssd-calc-allocated-bug
branch
from
fe9e96e
to
a96ca93
Compare
idryomov
approved these changes
Sep 9, 2021
idryomov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…load entries.
Currently, it will load existing entries after restart and cacl
m_bytes_allocated based on those entries. But currently there are
the following problems：
1: The allocated of write-same is not calculated for rwl & ssd cache.
2: for ssd cache, it not include the size of log-entry itself and don't
consider data alignment. This will cause less calculation and more
allocatation later. And will overwrite the data which don't flush to osd
and make data lost.
The calculation methods of ssd and rwl are different. So add new api
allocated_and_cached_data() to implement their own method.
For SSD cache, we dirtly use m_first_valid_entry & m_first_free_entry to
calc m_bytes_allocated.
Fixes:https://tracker.ceph.com/issues/52341
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox