ceph-volume: fix lvm activate --all --no-systemd #42912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a system without systemd then the `lvm activate --all --no-systemd` subcommand still calls systemd. We already allow users to activate a single OSD without systemd so there's no reason to not do the same with --all (because activate_all calls activate). Fixes: https://tracker.ceph.com/issues/25070 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
|
jenkins test ceph-volume lvm centos8-bluestore-create |
4 similar comments
|
jenkins test ceph-volume lvm centos8-bluestore-create |
|
jenkins test ceph-volume lvm centos8-bluestore-create |
|
jenkins test ceph-volume lvm centos8-bluestore-create |
|
jenkins test ceph-volume lvm centos8-bluestore-create |
guits
approved these changes
Sep 9, 2021
|
jenkins test ceph-volume lvm centos8-bluestore-create |
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a system without systemd then the
lvm activate --all --no-systemdsubcommand still calls systemd.
We already allow users to activate a single OSD without systemd so there's
no reason to not do the same with --all (because activate_all calls activate).
Fixes: https://tracker.ceph.com/issues/25070
Signed-off-by: Dimitri Savineau dsavinea@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox