mgr/cephadm: Add OSDService.post_remove() #42989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
cephadm/tests/test_cephadm.py:851:13: E124 closing bracket does not match visual indentation
cephadm/tests/test_cephadm.py:857:13: E124 closing bracket does not match visual indentation
cephadm/tests/test_cephadm.py:863:13: E124 closing bracket does not match visual indentation
cephadm/tests/test_cephadm.py:868:13: E124 closing bracket does not match visual indentation
cephadm/tests/test_cephadm.py:1385:13: E306 expected 1 blank line before a nested definition, found 0
4 E124 closing bracket does not match visual indentation
1 E306 expected 1 blank line before a nested definition, found 0
otherwise lgtm!
We should never remove the mon keyring. Let's move this piece of code into the MonService class Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Do not remove the osd.N keyring, if we failed to deploy the OSD, because we cannot recover from it. The OSD keys are created by ceph-volume and not by us. Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
sebastian-philipp
force-pushed
the
post-remove-osd-key-missing
branch
from
2a79e51
to
d7a4c57
Compare
adk3798
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not remove the osd.N keyring, if we failed to deploy the OSD, because
we cannot recover from it. The OSD keys are created by ceph-volume and not by
us.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox