ceph-volume: fix raw list with logical partition #43050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @BlaineEXE |
|
jenkins test ceph-volume tox |
|
we must be missing some tests |
This is a regression introduced by 9212420, when the host is using a logical partition then lsblk reports that partition as a child from the physical device. That logical partition is prefixed by the `└─` character. This leads the `raw list` subcommand to show the lsblk error on the stderr. ``` $ ceph-volume raw list {} stderr: lsblk: `-/dev/sda1: not a block device ``` The lsblk command output looks like: ``` $ lsblk --paths --output=NAME --noheadings /dev/sda └─/dev/sda1 /dev/sdb /dev/sdc /dev/sdd ``` Using the `--list` option with lsblk solves the issue. ``` $ lsblk --list --paths --output=NAME --noheadings /dev/sda /dev/sda1 /dev/sdb /dev/sdc /dev/sdd ``` Fixes: https://tracker.ceph.com/issues/52504 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
Let's test we use the expected args when we build the `lsblk` command to list the devices present on the node. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
fix_raw_list_with_lsblk
branch
from
bfd5bfb
to
959ea33
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
guits
approved these changes
Sep 7, 2021
sebastian-philipp
approved these changes
Sep 7, 2021
|
jenkins test ceph-volume lvm centos8-bluestore-create |
|
jenkins test ceph-volume lvm centos8-filestore-dmcrypt |
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
|
jenkins test ceph-volume lvm centos8-filestore-create |
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
This was referenced Sep 8, 2021
|
Thanks @dsavineau. Sorry for the regression. 🤦♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression introduced by 9212420, when the host is using a
logical partition then lsblk reports that partition as a child from the
physical device.
That logical partition is prefixed by the
└─character.This leads the
raw listsubcommand to show the lsblk error on the stderr.The lsblk command output looks like:
Using the
--listoption with lsblk solves the issue.Fixes: https://tracker.ceph.com/issues/52504
Signed-off-by: Dimitri Savineau dsavinea@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox