Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Fix failing config dashboard e2e check #43210

Merged
merged 1 commit into from Sep 21, 2021
Merged

mgr/dashboard: Fix failing config dashboard e2e check #43210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/configuration.e2e-spec.ts
View file
Open in desktop
Expand Up @@ -31,6 +31,7 @@ describe('Configuration page', () => {

beforeEach(() => {
configuration.clearTableSearchInput();
configuration.getTableCount('found').as('configFound');
});

after(() => {
Expand All @@ -49,14 +50,29 @@ describe('Configuration page', () => {
);
});

it('should show only modified configurations', () => {
it('should verify modified filter is applied properly', () => {
configuration.filterTable('Modified', 'no');
configuration.getTableCount('found').as('unmodifiedConfigs');

// Modified filter value to yes
configuration.filterTable('Modified', 'yes');
configuration.getTableCount('found').should('eq', 2);
});
configuration.getTableCount('found').as('modifiedConfigs');

cy.get('@configFound').then((configFound) => {
cy.get('@unmodifiedConfigs').then((unmodifiedConfigs) => {
const modifiedConfigs = Number(configFound) - Number(unmodifiedConfigs);
configuration.getTableCount('found').should('eq', modifiedConfigs);
});
});

it('should hide all modified configurations', () => {
// Modified filter value to no
configuration.filterTable('Modified', 'no');
configuration.getTableCount('found').should('gt', 1);
cy.get('@configFound').then((configFound) => {
cy.get('@modifiedConfigs').then((modifiedConfigs) => {
const unmodifiedConfigs = Number(configFound) - Number(modifiedConfigs);
configuration.getTableCount('found').should('eq', unmodifiedConfigs);
});
});
});
});
});