crush: fix v4 bucket feature detection (straw2) #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport: hammer Signed-off-by: Sage Weil <sage@redhat.com>
|
Looks good to me, but the gitbuilders are slow so not merging. |
|
Also I'm sure @dachary et al will be grateful if you can push the "fix has_v4_buckets()" commit with a backport tag. |
|
@liewegas @gregsfortytwo is right, I would be happy ;-). Although Backport: in the commit message is not convenient to track actual backporting, it is probably an appropriate place to say : "I think it would make sense to backport this patch to X,Y,Z". |
alg, not type! This bug made us incorrectly think we were using v4 features when user type 5 was being used. That's currently 'rack' with recent crush maps, but was other types for clusters that were created with older versions. This is clearly problematic as it will lock out non-hammer clients incorrectly, breaking deployments on upgrade. Fixes: #11364 Backport: hammer Signed-off-by: Sage Weil <sage@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Apr 10, 2015
crush: fix v4 bucket feature detection (straw2) Reviewed-by: Greg Farnum <gfarnum@redhat.com> Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to get backported to hammer too!