Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: make 'pg deep-scrub' command initiate a scrub #43244

Merged
merged 1 commit into from Nov 23, 2021

Conversation

ronen-fr
Copy link
Contributor

as the 'pg scrub' command does so.

Both commands push the 'last [deep] scrub' (respectively) back, to
cause the relevant type of scrub to be selected the next time we look for a PG to
scrub. But only the 'shallow' scrub timestamp is considered when deciding whether
a pg should be scrubbed.

Fixes: https://tracker.ceph.com/issues/52686

Signed-off-by: Ronen Friedman rfriedma@redhat.com

@ronen-fr
Copy link
Contributor Author

src/osd/PrimaryLogPG.cc Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

as the 'pg scrub' command does so.

Both commands push the 'last [deep] scrub' (respectively) back, to
cause the relevant type of scrub to be selected the next time we look for a PG to
scrub. But only the 'shallow' scrub timestamp is considered when deciding whether
a pg should be scrubbed.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
@neha-ojha
Copy link
Member

jenkins test api

@ronen-fr
Copy link
Contributor Author

Merged based on yuriw-2021-11-20_18:00:22-rados-wip-yuri6-testing-2021-11-20-0807-distro-basic-smithi and the
72 successful tests in http://pulpito.front.sepia.ceph.com/?branch=wip-rf-scrub-command.

The change forces a modification of the scrub-repair standalone test.

@ronen-fr ronen-fr merged commit f600acb into ceph:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants