crimson/os/seastore/.../btree_range_pin: fix is_parent_of #43301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansaction_direct Signed-off-by: Samuel Just <sjust@redhat.com>
The LBA tree implementation only requires that the start addr of a logical extent be contained within the leaf range. It's entirely possible for the end of a logical extent to extend past the end addr of the containing leaf node. Fixes: https://tracker.ceph.com/issues/52709 Signed-off-by: Samuel Just <sjust@redhat.com>
athanatos
force-pushed
the
sjust/wip-seastore-fixes-2021-09-24
branch
from
5b19b13
to
49affeb
Compare
athanatos
changed the title
liu-chunmei
reviewed
Sep 26, 2021
| @@ -21,7 +21,7 @@ struct lba_node_meta_t { | |||
| bool is_parent_of(const lba_node_meta_t &other) const { | |||
| return (depth == other.depth + 1) && | |||
| (begin <= other.begin) && | |||
| (end >= other.end); | |||
| (end > other.begin); | |||
There was a problem hiding this comment.
so finally, we will update parent node meta to include leaf node meta, right?
There was a problem hiding this comment.
Sorry? No, this is just fixing the is_parent_of predicate to be correct.
liu-chunmei
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.