Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/volumes/fs/operations: fix flake8 issues #43390

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

anuradhak26
Copy link

@anuradhak26 anuradhak26 commented Oct 1, 2021

mgr/volumes/fs/operations: Fix flake8 issues

Fixes : https://tracker.ceph.com/issues/51396

Signed-off-by: Anuradha Kulkarni anuradhak1990@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added cephfs Ceph File System pybind labels Oct 1, 2021
@varshar16 varshar16 changed the title osd:2021:Addressed flake8 issues for the file mgr/volumes/fs/operatio… mgr/volumes/fs/operations: fix flake8 issues Oct 1, 2021
Copy link
Contributor

@varshar16 varshar16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit title to mgr/volumes/fs/operations: fix flake8 issues. Otherwise looks good.

@varshar16
Copy link
Contributor

You can amend your commit with git commit --amend

@anuradhak26
Copy link
Author

You can amend your commit with git commit --amend

Changed the commit title to : commit title to mgr/volumes/fs/operations: fix flake8 issues

@varshar16
Copy link
Contributor

@anuradhak26 I don't see your new changes. You need to force push the changes. git push -f <repo-name> <branch-name>

Fixes : https://tracker.ceph.com/issues/51396

Signed-off-by: Anuradha Kulkarni <anuradhak1990@gmail.com>
Copy link
Contributor

@varshar16 varshar16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

batrick added a commit to batrick/ceph that referenced this pull request Oct 4, 2021
* refs/pull/43390/head:
	mgr/volumes/fs/operations : Fix flake8 issues
@batrick
Copy link
Member

batrick commented Oct 6, 2021

@batrick batrick merged commit 7f6aa14 into ceph:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants