os/bluestore/bluefs: Fix false collision with lockdep module #43589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclamk
requested review from
neha-ojha and
liewegas
and removed request for
liewegas
|
thanks @aclamk. i ran the same test with this fix, and now it's failing with |
aclamk
force-pushed
the
fix-bluefs-fine-grain-locks-52939
branch
from
4b23ecf
to
e292475
Compare
Usually sequence of locking is 1) FileWriter 2) File. In _compact_log_async_LD_NF_D it was in reversed order. No real deadlock was possible, but lockdep complained. Bonus: Improved lock dependency graph. Fixes: https://tracker.ceph.com/issues/52939 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
aclamk
force-pushed
the
fix-bluefs-fine-grain-locks-52939
branch
from
e292475
to
21e5a0f
Compare
|
@cbodley Thanks for checking this so quickly. |
ifed01
approved these changes
Oct 20, 2021
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
@aclamk pls rebase |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually sequence of locking is
In _compact_log_async_LD_NF_D it was in reversed order.
No real deadlock was possible, but lockdep complained.
Fixes: https://tracker.ceph.com/issues/52939
Signed-off-by: Adam Kupczyk akupczyk@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox