test/librbd: harden RemoveFullTry tests #43633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around write-back or write-around cache getting enabled (e.g. if one runs the tests with rbd_cache_writethrough_until_flush disabled). Fixes: https://tracker.ceph.com/issues/52883 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
…cache
Persistent writeback cache messes with pool quota enforcement on the
OSD side and we don't always break out of the write zeroes loop:
src/test/librbd/test_librbd.cc:2165: Failure
Value of: off >= quota && off < size
Actual: false
Expected: true
Unfortunately persistent writeback cache doesn't honor FUA [1] so the
workaround for volatile caches from the previous patch doesn't apply.
[1] https://tracker.ceph.com/issues/49715
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
RemoveFullTry tests fill up the pool and expect EDQUOT. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
trociny
approved these changes
Oct 24, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is master rebased version of #43575
Depends on #43568 and #43573. I'll rebase once both of them get merged.