[DNM] librbd: avoid blocking AIO API methods #4364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 14, 2015 13:57
The queue holds a collection of Context pointers that will be completed by the thread pool. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Add preliminary support for queuing incoming AIO requests into a work queue to avoid blocking the client. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Enqueue all AIO API methods within the new librbd thread pool to reduce the possibility of any blocking operations. This change alters the potential return codes from the AIO API methods. Legacy errors such as -EROFS, -ENOENT, etc will now be returned via the provided completion and aio_read will no longer return the number of bytes read. Fixes: #11056 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Helper method to handle passing fatal errors generated within librbd (not from the OSDs) back to the client. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Allow the client of SimpleThrottle to detect an async error so that it can exit early. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 2cc5f8a)
All failures should be returned via the AioCompletion. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@dillaman is it still DNM ? |
|
Still DNM - not in master yet |
|
This has diverged somewhat from the final implementation in master -- closing. |
|
Replaced by PR #4854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11056