rgw: ListMultipartUploads returns the real upload Owners #43715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
also added override specifiers in RadosMultipartUpload Signed-off-by: Casey Bodley <cbodley@redhat.com>
the ListMultipartUploads response includes an Owner and Initiator for each multipart upload in the list, but we were just returning the requesting user for every upload instead we get the real owner field out of rgw_bucket_dir_entry when listing the uploads, so need to store that with MultipartUpload for later use in RGWListBucketMultiparts_ObjStore_S3::send_response() Fixes: https://tracker.ceph.com/issues/52716 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
jenkins test make check |
|
added test case at ceph/s3-tests#415, and verified that it fails without this pr and passes with |
dang
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ListMultipartUploads response includes an Owner and Initiator for each multipart upload in the list, but we were just returning the requesting user for every upload instead
we get the real owner field out of rgw_bucket_dir_entry when listing the uploads, so need to store that with MultipartUpload for later use in RGWListBucketMultiparts_ObjStore_S3::send_response()
Fixes: https://tracker.ceph.com/issues/52716
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox