mgr/prometheus: Update rule format and enhance SNMP support #43783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the tox output [paul@rhp1gen3 tests]$ tox
py3 installed: attrs==21.2.0,beautifulsoup4==4.10.0,bs4==0.0.1,iniconfig==1.1.1,packaging==21.0,pluggy==1.0.0,py==1.10.0,pyparsing==3.0.3,pytest==6.2.5,PyYAML==6.0,soupsieve==2.2.1,toml==0.10.2
py3 run-test-pre: PYTHONHASHSEED='3007607034'
py3 run-test: commands[0] | pytest -rA test_syntax.py test_unittests.py
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.9.7, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
cachedir: .tox/py3/.pytest_cache
rootdir: /home/paul/git/ceph/monitoring/prometheus/tests
collected 8 items
test_syntax.py ..... [ 62%]
test_unittests.py ... [100%]
===================================================================================================== PASSES ======================================================================================================
============================================================================================= short test summary info =============================================================================================
PASSED test_syntax.py::test_alerts_present
PASSED test_syntax.py::test_unittests_present
PASSED test_syntax.py::test_rules_format
PASSED test_syntax.py::test_unittests_format
PASSED test_syntax.py::test_rule_syntax
PASSED test_unittests.py::test_alerts_present
PASSED test_unittests.py::test_unittests_present
PASSED test_unittests.py::test_run_unittests
================================================================================================ 8 passed in 5.33s ================================================================================================
py3 run-test: commands[1] | ./validate_rules.py
Checking rule groups
cluster health : ..
mon : .....
osd : ................
mds : .......
mgr : ..
pgs : .........
nodes : .....
pools : ....
healthchecks : .
cephadm : ...
PrometheusServer : .
rados : .
Summary
Rule file : ../alerts/ceph_default_alerts.yml
Unit Test file : test_alerts.yml
Rule groups processed : 12
Rules processed : 56
SNMP OIDs declared : 34
Rule errors : 0
Rule warnings : 0
Rule name duplicates : 0
Unit tests missing : 0
No problems detected in the rule file
No problems detected in unit tests file
_____________________________________________________________________________________________________ summary _____________________________________________________________________________________________________
py3: commands succeeded
congratulations :)
|
epuertat
approved these changes
Nov 3, 2021
Comment on lines
+30
to
+32
| org cluster (alerts) source Category | ||
| 1.3.6.1 .4 .1 .50495 .1 .2 .1 .2 (Ceph Health) |
There was a problem hiding this comment.
@liewegas I checked the IANA registry for the 50495 org and saw your newdream email address. Should we update that address to some generic ceph.io address?
epuertat
reviewed
Nov 4, 2021
There was a problem hiding this comment.
BTW @pcuzner according to this conversation, could you plz add the RECENT_CRASH alert too? Thanks!
Rules now adhere to the format defined by Prometheus.io. This changes alert naming and each alert now includes a a summary description to provide a quick one-liner. In addition to reformatting some missing alerts for MDS and cephadm have been added, and corresponding tests added. The MIB has also been refactored, so it now passes standard lint tests and a README included for devs to understand the OID schema. Fixes: https://tracker.ceph.com/issues/53111 Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
|
@epuertat Doh. Added, and squashed. |
Thanks! |
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules now adhere to the format defined by Prometheus.io.
This changes alert naming and each alert now includes a
a summary description to provide a quick one-liner.
In addition to reformatting some missing alerts for MDS and
cephadm have been added, and corresponding tests added.
The MIB has also been refactored, so it now passes standard
lint tests and a README included for devs to understand the
OID schema.
Fixes: https://tracker.ceph.com/issues/53111
Signed-off-by: Paul Cuzner pcuzner@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox