Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix missing alert rule details #43797

Merged
merged 1 commit into from Nov 4, 2021
Merged

mgr/dashboard: fix missing alert rule details #43797

merged 1 commit into from Nov 4, 2021

Conversation

epuertat
Copy link
Member

@epuertat epuertat commented Nov 3, 2021 •
edited

Please note the wrong detail fields (_selected, hasMultiSelect, etc):

BEFORE

image

AFTER

image

Fixes: https://tracker.ceph.com/issues/53144
Signed-off-by: Ernesto Puerta epuertat@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@epuertat
mgr/dashboard: fix missing alert rule details
b47f9c8 
Fixes: https://tracker.ceph.com/issues/53144
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
@epuertat epuertat requested a review from a team as a code owner November 3, 2021 17:59
@epuertat epuertat requested review from pereman2 and nizamial09 and removed request for a team November 3, 2021 17:59
@github-actions github-actions bot added the pybind label Nov 3, 2021
@github-actions github-actions bot added this to In progress in Dashboard Nov 3, 2021
@alfonsomthd alfonsomthd requested a review from p-se November 4, 2021 08:23
Dashboard automation moved this from In progress to Reviewer approved Nov 4, 2021
@epuertat epuertat merged commit 1317913 into ceph:master Nov 4, 2021
Dashboard automation moved this from Reviewer approved to Done Nov 4, 2021
@epuertat epuertat deleted the fix-53144-master branch November 4, 2021 09:17
@epuertat epuertat mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@pereman2 pereman2 pereman2 approved these changes

@nizamial09 nizamial09 Awaiting requested review from nizamial09 nizamial09 was automatically assigned from ceph/dashboard

@Waadkh7 Waadkh7 Awaiting requested review from Waadkh7

@pcuzner pcuzner Awaiting requested review from pcuzner

@p-se p-se Awaiting requested review from p-se

Assignees
No one assigned
Labels
dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
3 participants
@epuertat @alfonsomthd @pereman2