octopus: librbd/object_map: rbd diff between two snapshots lists entire image content #43806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content Problem: rbd diff between two snapshots lists entire image content with `whole-object` switch. Solution: While computing resize diff during object map do not mark state as new data unless diff state is valid. Fixes: https://tracker.ceph.com/issues/50787 Signed-off-by: Sunny Kumar <sunkumar@redhat.com> (cherry picked from commit 399a45e)
…f enable This patch adds a test condition to test fast diff between two snapshots with whole-object switch. `TestMockObjectMapDiffRequest.EndDelta` expects diff state `DIFF_STATE_DATA_UPDATED` which is an incorrect expectation when diff is calculated between two snapshots. Fixes: https://tracker.ceph.com/issues/50787 Signed-off-by: Sunny Kumar <sunkumar@redhat.com> (cherry picked from commit 8d62c4a)
trociny
approved these changes
Nov 4, 2021
|
Pls add |
idryomov
approved these changes
Jan 20, 2022
|
@yuriw I looked at that card and I don't understand why this PR was deemed to be the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/53027
backport of #41657
parent tracker: https://tracker.ceph.com/issues/50787
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh