os/bluestore: do not select absent device in volume selector #43818
Conversation
Fixes: ttps://tracker.ceph.com/issues/53139 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
| if (slow_size == 0) { | ||
| slow_size = db_size; | ||
| } | ||
| res.emplace_back(base + ".slow", slow_size); |
There was a problem hiding this comment.
@ifed01 Could you please remind me, why we must provide base + ".slow" to RocksDB ?
I mean - cant we just provide base ?
There was a problem hiding this comment.
Originally we provide db.slow vs. db for RocksDB to be able to indicate less frequently used data. Hence we're able to put them to larger but slower main device.
This works fine for 2+ device setups.
For single device setup we had that "dual-folder" provisioning in RocksDBBlueFSVolumeSelector from its introduction but it wasn't used since that selector isn't created for single device setup at all.
For OriginalVolumeSelector in #42992 I introduced dual folder provisioning for single device setup as well recently - to fix the case when files originally put into db.slow are still referred via this subdir after DB volume migration/removal.
So now we have unconditional dual-folder setup for both selectors.
And it's still a no-op for RocksDBBlueFSVolumeSelector as the latter is not used for single-device deployment for now.
Perhaps we can change this some day though, primarily for the sake of getting rid of the original selector and having a bit better bluefs stats reporting..
So while preparing this patch (which is primarily for original selector) I additionally tried RocksDBBlueFSVolumeSelector in a single device setup and discovered that it should adjust indicated capacity for slow folder for RocksDB to parse that properly. The latter was complaining about size set to 0...
So despite this specific modification in RocksDBBlueFSVolumeSelector::get_path() is generally unrelated to the proposed fix I kept it as-is for the sake of future selector unification.
|
rados approved, unrelated failures tracked in https://tracker.ceph.com/issues/53287 |
Fixes: https://tracker.ceph.com/issues/53139
Signed-off-by: Igor Fedotov igor.fedotov@croit.io
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox