Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlueStore: Omap upgrade to per-pg fix fix #43916

Closed
wants to merge 2 commits into from
Closed

BlueStore: Omap upgrade to per-pg fix fix #43916

wants to merge 2 commits into from

Conversation

aclamk
Copy link
Contributor

@aclamk aclamk commented Nov 13, 2021 •
edited

During fix of https://tracker.ceph.com/issues/53062 small regression has been introduced.
Some keys got deleted during upgrade.

Fixes: https://tracker.ceph.com/issues/53261

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
  • Teuthology
    • Completed teuthology run
    • No teuthology test necessary (e.g., documentation)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@aclamk
os/bluestore: Add more legacy -> per PG upgrade tests
4644aed 
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
@aclamk
os/bluestore: Fix omap upgrade to per-pg scheme
7a45be1 
This is fix to regression introduced by fix to omap upgrade: ceph#43687
The problem was that we always skipped first omap entry.
This worked fine with objects having omap header key.
For objects without header key we skipped first actual omap key.

Fixes: https://tracker.ceph.com/issues/53261

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
@github-actions github-actions bot added this to the pacific milestone Nov 13, 2021
ifed01
ifed01 reviewed Nov 13, 2021
View reviewed changes
Copy link
Contributor

@ifed01 ifed01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! But let's follow the procedure and submit a PR against master first. Then backport it to Pacific

@aclamk
Copy link
Contributor Author

aclamk commented Nov 15, 2021

Closing to:

  • first make fix to master
  • change branch name

@aclamk aclamk closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifed01 ifed01 ifed01 approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees
No one assigned
Labels
bluestore bug-fix core tests
Projects
None yet
Milestone
pacific
2 participants
@aclamk @ifed01