Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: ceph-volume: fix bug with miscalculation of required db/wal slot size for VGs with multiple PVs #43948

Merged
merged 2 commits into from Nov 18, 2021

Conversation

guits
Copy link
Contributor

@guits guits commented Nov 16, 2021

backport tracker: https://tracker.ceph.com/issues/53278


backport of #43300
parent tracker: https://tracker.ceph.com/issues/52730

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@guits guits requested a review from a team as a code owner November 16, 2021 14:21
@guits guits added this to the pacific milestone Nov 16, 2021
@guits
Copy link
Contributor Author

guits commented Nov 16, 2021

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Nov 16, 2021

jenkins test ceph-volume all

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type_dmcrypt

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type_dmcrypt_explicit

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type_explicit

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type_dmcrypt_explicit

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type_explicit

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume batch centos8-bluestore-mixed_type_dmcrypt

cfsnyder and others added 2 commits November 17, 2021 18:22
… for VGs with multiple PVs

Previous logic for calculating db/wal slot sizes made the assumption that there would only be
a single PV backing each db/wal VG. This wasn't the case for OSDs deployed prior to v15.2.8,
since ceph-volume previously deployed multiple SSDs in the same VG. This fix removes the
assumption and does the correct calculation in either case.

Fixes: https://tracker.ceph.com/issues/52730
Signed-off-by: Cory Snyder <csnyder@iland.com>
(cherry picked from commit cd6aa13)
we need to create a file with a larger size.
see ceph#43300 (comment)

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 8af00e2)
@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume all

@guits
Copy link
Contributor Author

guits commented Nov 17, 2021

jenkins test ceph-volume tox

@guits guits merged commit 8f96ee2 into ceph:pacific Nov 18, 2021
@guits guits deleted the wip-53278-pacific branch November 18, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants