rgwlc: permit lifecycle processing for a single bucket #44139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permit a --bucket option to be passed to radosgw-admin lc process, and propagate the bucket name to lifecycle processing, and process only the named bucket if one is provided. Fixes: https://tracker.ceph.com/issues/53430 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-rgw-lcselect
branch
from
8fb3a3d
to
9ddc223
Compare
|
jenkins retest this please |
|
it doesn't make sense to search all lc partitions for the bucket, let's see if we can fix that... |
|
Feel free to modify zipper APIs if necessary. I did the minimum necessary to make it work, and they may not be optimal. |
cbodley
reviewed
Nov 30, 2021
mattbenjamin
force-pushed
the
wip-rgw-lcselect
branch
from
8aa1127
to
d1c24fc
Compare
mattbenjamin
force-pushed
the
wip-rgw-lcselect
branch
from
d1c24fc
to
d89fb97
Compare
cbodley
reviewed
Dec 1, 2021
| if (ret < 0) | ||
| return 0; | ||
|
|
||
| if (! (cct->_conf->rgw_lc_lock_max_time == 9969)) { |
There was a problem hiding this comment.
what does this check accomplish? it's not clear where 9969 comes from. there's also a local variable max_lock_secs that stores the value of this config option
There was a problem hiding this comment.
this is debugging magic, try to ignore
mattbenjamin
force-pushed
the
wip-rgw-lcselect
branch
from
d89fb97
to
25f508c
Compare
mattbenjamin
force-pushed
the
wip-rgw-lcselect
branch
from
f9cb1cd
to
7bb0215
Compare
|
oops, forgot to constify the unique_ptr |
cbodley
reviewed
Dec 1, 2021
Looks up the shard index of the corresponding bucket, and only buckets in the corresponding shard are considered for processing. This has a side effect of matching buckets by id, and also adds support for --tenant. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-rgw-lcselect
branch
from
86b2f64
to
af11694
Compare
cbodley
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permit a --bucket option to be passed to radosgw-admin lc process,
and propagate the bucket name to lifecycle processing, and process
only the named bucket if one is provided.
Fixes: https://tracker.ceph.com/issues/53430
Signed-off-by: Matt Benjamin mbenjamin@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox