Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: Omit MANY_OBJECTS_PER_PG warning when autoscaler is on #44280

Merged
merged 2 commits into from Dec 16, 2021
Merged

mon: Omit MANY_OBJECTS_PER_PG warning when autoscaler is on #44280

merged 2 commits into from Dec 16, 2021

Conversation

chrisphoffman
Copy link
Contributor

@chrisphoffman chrisphoffman commented Dec 10, 2021 •
edited

mon: Omit message when autoscaler is on
Add a conditional statement when autoscaler is
set to ON to omit message when about pool having
many more objects per pg than cluster average.

Fixes: https://tracker.ceph.com/issues/53516

Signed-off-by: Christopher Hoffman choffman@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@neha-ojha
Copy link
Member

jenkins test make check

neha-ojha
neha-ojha approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you please update the commit message to say mon: Omit MANY_OBJECTS_PER_PG warning when autoscaler is on, to make it clear which warning is being omitted and update https://docs.ceph.com/en/latest/rados/operations/health-checks/#many-objects-per-pg accordingly

@ljflores
Copy link
Contributor

jenkins test make check

@chrisphoffman
mon: Omit MANY_OBJECTS_PER_PG warning when autoscaler is on
8d846c3 
Add a conditional statement when autoscaler is
set to ON to omit message when about pool having
many more objects per pg than cluster average.

Fixes: https://tracker.ceph.com/issues/53516

Signed-off-by: Christopher Hoffman <choffman@redhat.com>
@chrisphoffman chrisphoffman changed the title mon: Omit message when autoscaler is on mon: Omit MANY_OBJECTS_PER_PG warning when autoscaler is on Dec 13, 2021
@ljflores ljflores removed the needs-qa label Dec 13, 2021
@ljflores
Copy link
Contributor

@chrisphoffman this is a nit, but would you mind amending your last commit (the docs one) to say `doc/rados/operations:" at the beginning? This is just to keep commit titles consistent.

After that, go ahead and add the needs-qa tag back

@chrisphoffman
doc/rados/operations: Updated rados docs to include
6c51b1f 
changes to health-checks in MANY_OBJECTS_PER_PG
warning when autoscale is on.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>
@chrisphoffman
Copy link
Contributor Author

@chrisphoffman this is a nit, but would you mind amending your last commit (the docs one) to say `doc/rados/operations:" at the beginning? This is just to keep commit titles consistent.

After that, go ahead and add the needs-qa tag back

Done. Thank you both for your suggestions.

@chrisphoffman
Copy link
Contributor Author

jenkins test api

@neha-ojha
Copy link
Member

Run - https://pulpito.ceph.com/choffman-2021-12-14_19:02:26-rados-wip-chris-warn-pg-distro-default-smithi
Rerun - https://pulpito.ceph.com/choffman-2021-12-15_14:40:21-rados-wip-chris-warn-pg-distro-default-smithi/

Unrelated failures

@neha-ojha neha-ojha merged commit fc8797c into ceph:master Dec 16, 2021
@chrisphoffman chrisphoffman mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees
No one assigned
Labels
core documentation mon needs-qa
Projects
None yet
Milestone
No milestone
3 participants
@chrisphoffman @neha-ojha @ljflores