Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/qemu: switch nbd devices from virtio to ide #44282

Merged
merged 3 commits into from Jan 25, 2022

Conversation

orozery
Copy link
Contributor

@orozery orozery commented Dec 12, 2021

I'm opening this as a workaround for:
https://tracker.ceph.com/issues/53587

@trociny I actually tried using rbd encryption with qemu 6.1.0, but that failed with RBD library does not support image encryption.
This is because that qemu was compiled using librbd which does not have encryption.
Specifically, this package:
https://centos.pkgs.org/8-stream/centos-appstream-x86_64/qemu-kvm-block-rbd-6.1.0-5.module_el8.6.0+1040+0ae94936.x86_64.rpm.html

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

qa/tasks/qemu.py Show resolved Hide resolved
This commit is a workaround of a bug in the virtio interface in qemu 6.1.0+.

Fixes: https://tracker.ceph.com/issues/53587
Signed-off-by: Or Ozeri <oro@il.ibm.com>
@orozery
Copy link
Contributor Author

orozery commented Dec 13, 2021

jenkins retest this please

@orozery
Copy link
Contributor Author

orozery commented Jan 12, 2022

jenkins retest this please

@orozery
Copy link
Contributor Author

orozery commented Jan 12, 2022

I guess there's no way to re-run the docs/readthedocs.org:ceph job

@trociny
Copy link
Contributor

trociny commented Jan 12, 2022

@orozery docs/readthedocs.org:ceph is not mandatory for merge and may be ignored in this case as sure it is not related.

@idryomov idryomov removed the needs-qa label Jan 19, 2022
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that xfstests are actually run, this fails because virtio device names are hard-coded in qa/run_xfstests_qemu.sh:

./"${SCRIPT}" -c 1 -f xfs -t /dev/vdb -s /dev/vdc \
    1-7 9-17 19-26 28-49 51-61 63 66-67 69-79 83 85-105 108-110 112-135 \
    137-170 174-191 193-204 206-217 220-227 230-231 233 235-241 243-249 \
    251-262 264-278 281-286 288-289

Probably need to introduce TEST_DEV and SCRATCH_DEV variables which would default to /dev/vdb and /dev/vdc and be reset to /dev/sdb and /dev/sdc if existence check fails.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@idryomov
Copy link
Contributor

Probably need to introduce TEST_DEV and SCRATCH_DEV variables which would default to /dev/vdb and /dev/vdc and be reset to /dev/sdb and /dev/sdc if existence check fails.

I went ahead and did that.

@idryomov idryomov added the needs-quincy-backport backport required for quincy label Jan 22, 2022
All three are skipped with virtio disks:

251	 [not run] FITRIM not supported on /dev/vdc
260	 [not run] FITRIM not supported on /dev/vdc
288	 [not run] FITRIM not supported on /dev/vdc

But 260 and 288 fail with ide disks, where discard defaults to on.  The
ancient kernel in our ubuntu-12.04.qcow2 doesn't support virtio discard
anyway so let's just disable them for consistency.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@idryomov
Copy link
Contributor

168 appears to be flaky as well -- it's supposed to be skipped with "Assuming DMAPI modules are not loaded" but it occasionally gets past that check.

@idryomov
Copy link
Contributor

jenkins test make check

@idryomov idryomov merged commit 82219b3 into ceph:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants