ceph-volume: improve mpath devices support #44304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test ceph-volume tox |
guits
force-pushed
the
guits-fix-cv-batch-mpath
branch
from
e0891ba
to
a5502a6
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
leseb
approved these changes
Dec 14, 2021
sebastian-philipp
approved these changes
Dec 15, 2021
guits
force-pushed
the
guits-fix-cv-batch-mpath
branch
from
133fd13
to
62ae17d
Compare
|
jenkins test make check |
guits
force-pushed
the
guits-fix-cv-batch-mpath
branch
from
62ae17d
to
33ae4ee
Compare
|
jenkins test ceph-volume tox |
ee8887f was intended for adding mpath devices support in ceph-volume but it has missed the lvm batch scenario. This also fixes the zapping of mpath devices prepared with `ceph-volume raw` Fixes: https://tracker.ceph.com/issues/52908 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This test checks that Device.is_device() returns True for a mpath device. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This fixes a typo in ceph-volume documentation. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This fixes 2 typo in ceph-volume tests. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
guits-fix-cv-batch-mpath
branch
from
33ae4ee
to
b07bd3e
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
|
Failure Reason:
|
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ee8887f was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with
ceph-volume rawFixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com