Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add ceph-common DENABLE_SHARED=OFF support #44321

Merged
merged 1 commit into from Feb 23, 2022
Merged

cmake: add ceph-common DENABLE_SHARED=OFF support #44321

merged 1 commit into from Feb 23, 2022

Conversation

Alexponomarev7
Copy link

@Alexponomarev7 Alexponomarev7 commented Dec 15, 2021

I needed to build librados STATIC, for this purpose i found DENABLE_SHARED=OFF.
But librados depends on ceph-common which is always build dynamic. So i had this problem:
image
This small patch fixes this issue.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

Add the possibility to build librados static.

Signed-off-by: Alex Ponomarev <alex.ponomarev@phystech.edu>
@Alexponomarev7
Copy link
Author

@tchaikov Any updates?

@ljflores
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/?branch=wip-yuri4-testing-2022-02-18-0800

Failures, unrelated:
https://tracker.ceph.com/issues/45721
https://tracker.ceph.com/issues/53422
https://tracker.ceph.com/issues/51627
https://tracker.ceph.com/issues/53680
https://tracker.ceph.com/issues/52320
https://tracker.ceph.com/issues/52124

Details:
1. CommandFailedError: Command failed (workunit test rados/test_python.sh) FAIL: test_rados.TestWatchNotify.test - Ceph - RADOS
2. tasks.cephfs.test_nfs.TestNFS.test_export_create_with_non_existing_fsname: AssertionError: NFS Ganesha cluster deployment failed - Ceph - Orchestrator
3. FAILED ceph_assert(attrs || !recovery_state.get_pg_log().get_missing().is_missing(soid) || (it_objects != recovery_state.get_pg_log().get_log().objects.end() && it_objects->second->op == pg_log_entry_t::LOST_REVERT)) - Ceph - RADOS
4. ERROR:tasks.rook:'waiting for service removal' reached maximum tries (90) after waiting for 900 seconds - Ceph - Orchestrator
5. unable to get monitor info from DNS SRV with service name: ceph-mon - Ceph - Orchstrator
6. Invalid read of size 8 in handle_recovery_delete() - Ceph - RADOS

@ljflores
Copy link
Contributor

jenkins test windows

@yuriw yuriw merged commit 69e3bca into ceph:master Feb 23, 2022
@ljflores ljflores mentioned this pull request Mar 8, 2022
@Alexponomarev7 Alexponomarev7 deleted the fix-static-librados-build branch September 20, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants