Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: fix osd cannot be started after being set to stop #44363

Closed
wants to merge 1 commit into from
Closed

osd: fix osd cannot be started after being set to stop #44363

wants to merge 1 commit into from

Conversation

NUABO
Copy link
Contributor

@NUABO NUABO commented Dec 20, 2021 •
edited

after osd stop is set, there will always be a stop mark in the osd map,
so when the osd is restarted, the stop mark will be detected and the osd
process will be killed immediately, so when it is not active,
only stop osd in is_waiting_for_healthy

Fixes: https://tracker.ceph.com/issues/53667
Signed-off-by: tan changzhi 544463199@qq.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the core label Dec 20, 2021
@NUABO NUABO force-pushed the tanchangzhi branch 2 times, most recently from ad95dd3 to 8f999c9 Compare December 21, 2021 03:13
@NUABO NUABO closed this Dec 21, 2021
@NUABO NUABO reopened this Dec 21, 2021
@NUABO
Copy link
Contributor Author

NUABO commented Dec 24, 2021

@neha-ojha @xiexingguo please review

osd: fix osd cannot be started after being set to stop
5126616 
after osd stop is set, there will always be a stop mark in the osd map,
so when the osd is restarted, the stop mark will be detected and the osd
process will be killed immediately, so when it is not active,
only stop osd in is_waiting_for_healthy.

Fixes: https://tracker.ceph.com/issues/53667
Signed-off-by: tan changzhi <544463199@qq.com>
@NUABO NUABO closed this Feb 5, 2022
@NUABO NUABO reopened this Feb 5, 2022
@github-actions github-actions bot added the mon label Mar 16, 2022
@neha-ojha
Copy link
Member

@NUABO it seems that you have accidentally pushed the commit from #45409 to this PR

@NUABO
Copy link
Contributor Author

NUABO commented Mar 17, 2022

@NUABO it seems that you have accidentally pushed the commit from #45409 to this PR

sorry, I have resubmitted, thank you for reminding me.

@NUABO
Copy link
Contributor Author

NUABO commented Apr 26, 2022

@xiexingguo please help to review, this bug will cause the osd to not be able to be pulled up at startup, it is urgent, thank you

@neha-ojha neha-ojha self-requested a review April 26, 2022 16:12
@djgalloway djgalloway changed the base branch from master to main June 1, 2022 16:52
@djgalloway djgalloway requested a review from a team as a code owner June 1, 2022 16:52
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 31, 2022
@ljflores
Copy link
Contributor

jenkins test make check

@ljflores
Copy link
Contributor

@xiexingguo ping?

@github-actions github-actions bot removed the stale label Aug 25, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 29, 2022
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jan 28, 2023
@NUABO
Copy link
Contributor Author

NUABO commented May 6, 2023

hi @ljflores , could you please push for the review of this pr ？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiexingguo xiexingguo Awaiting requested review from xiexingguo

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees
No one assigned
Labels
core mon stale
Projects
None yet
Milestone
No milestone
3 participants
@NUABO @neha-ojha @ljflores