Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix timeout error in dashboard cephadm e2e job #44364

Merged
merged 1 commit into from Dec 23, 2021
Merged

mgr/dashboard: fix timeout error in dashboard cephadm e2e job #44364

merged 1 commit into from Dec 23, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Dec 20, 2021 •
edited

  1. Fix the timeout error happening in the dashboard e2e job

Most of the time our test is getting timed out while searching for an item
in the table. Its because .clear().type() is not clearing the content
in the search field sometimes and that creates a wrong data to be
entered into the search field and it starts searching based on this
wrong name. To avoid this I am explicitly clearing the search area
before typing.

Fixes: https://tracker.ceph.com/issues/53672

Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added this to In progress in Dashboard Dec 20, 2021
@nizamial09 nizamial09 changed the title [WIP] mgr/dashboard: testing the cause of timeouts [DNM] mgr/dashboard: testing the cause of timeouts Dec 20, 2021
@nizamial09 nizamial09 added the DNM label Dec 20, 2021
@nizamial09 nizamial09 changed the title [DNM] mgr/dashboard: testing the cause of timeouts [DNM] mgr/dashboard: testing the cause of dashboard cephadm e2e timeouts Dec 20, 2021
@nizamial09 nizamial09 force-pushed the e2e-fixups branch 9 times, most recently from 35762d3 to f30a92a Compare December 20, 2021 12:06
@nizamial09 nizamial09 changed the title [DNM] mgr/dashboard: testing the cause of dashboard cephadm e2e timeouts [DNM] mgr/dashboard: fix timeout error in dashboard cephadm e2e job Dec 20, 2021
@nizamial09 nizamial09 force-pushed the e2e-fixups branch 2 times, most recently from fbfd766 to 4be49e8 Compare December 23, 2021 11:11
@nizamial09 nizamial09 changed the title [DNM] mgr/dashboard: fix timeout error in dashboard cephadm e2e job mgr/dashboard: fix timeout error in dashboard cephadm e2e job Dec 23, 2021
@nizamial09 nizamial09 marked this pull request as ready for review December 23, 2021 11:44
@nizamial09 nizamial09 requested a review from a team as a code owner December 23, 2021 11:44
@nizamial09 nizamial09 requested review from pereman2 and aaSharma14 and removed request for a team December 23, 2021 11:44
@nizamial09 nizamial09 removed the DNM label Dec 23, 2021
@nizamial09
mgr/dashboard: fix timeout error in dashboard cephadm e2e job
fed358d 
1. Fix the timeout error happening in the dashboard e2e job
2. Take care of the flaky force maintenance check

Most of the time our test is getting timed out while searching for an item
in the table. Its because `.clear().type()` is not clearing the content
in the search field sometimes and that creates a wrong data to be
entered into the search field and it starts searching based on this
wrong name. To avoid this I am explicitly clearing the search area
before typing.

Fixes: https://tracker.ceph.com/issues/53672
Signed-off-by: Nizamudeen A <nia@redhat.com>
Dashboard automation moved this from In progress to Reviewer approved Dec 23, 2021
@nizamial09 nizamial09 added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Dec 23, 2021
@nizamial09
Copy link
Member Author

jenkins test api

@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Dec 23, 2021
@epuertat epuertat merged commit fdd6b79 into ceph:master Dec 23, 2021
Dashboard automation moved this from Ready-to-merge to Done Dec 23, 2021
@epuertat epuertat deleted the e2e-fixups branch December 23, 2021 16:23
@nizamial09 nizamial09 mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@pereman2 pereman2 Awaiting requested review from pereman2 pereman2 was automatically assigned from ceph/dashboard

@Waadkh7 Waadkh7 Awaiting requested review from Waadkh7

@epuertat epuertat Awaiting requested review from epuertat

Assignees
No one assigned
Labels
dashboard pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
4 participants
@nizamial09 @alfonsomthd @aaSharma14 @epuertat