mount.ceph: fix the handling of new-syntax device names #44456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old one gives a 404 error now. Signed-off-by: Jeff Layton <jlayton@redhat.com>
With the new mount device syntax, the mount helper will end up prepending "client." to whatever device string is passed down. If you then go to recreate that mount later from the info in /proc/mounts, you'll end up getting back an error because it'll try to prepend "client." again. There is no reason to send a fully-qualified principal name down to the kernel since it can only use client.* principals anyway. Fix the mount helper to track the unqualified name internally and only fully-qualify it when we're scraping the config for info. Fixes: https://tracker.ceph.com/issues/53765 Signed-off-by: Jeff Layton <jlayton@redhat.com>
batrick
approved these changes
Jan 4, 2022
|
I don't think this has been backported to earlier releases yet, so it should be ok to just fix it in mainline. If we do end up backporting this feature later (and that might be a good thing to do), we can just make sure to pick this patch as well. |
lxbsz
approved these changes
Jan 5, 2022
vshankar
approved these changes
Jan 5, 2022
jtlayton
requested review from
ceph-jenkins and
a team
and removed request for
ceph-jenkins
vshankar
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main patch in this fixes the handling of new-syntax device names. The code currently prepends "client." to the device string that it passes to the kernel, but it can't accept that syntax later if someone tries to recreate the mount.
Also, fix the URL in the specfile that points to the "bcond_" doc pages.
Fixes: https://tracker.ceph.com/issues/53765