Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mds: fix seg fault in expire_recursive #44477

Merged
merged 1 commit into from Feb 9, 2022
Merged

mds: fix seg fault in expire_recursive #44477

merged 1 commit into from Feb 9, 2022

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Jan 6, 2022 •
edited

Range-based for should not be used when we are altering the container.
Use iterator explicitly instead.

Fixes: https://tracker.ceph.com/issues/53805
Signed-off-by: 胡玮文 huww98@outlook.com

Discovered while debugging #44335. I don't know why it works before. Maybe just my gcc from Ubuntu 20.04 don't like it.

This may not be reproduced in official builds, so I checked "Code cleanup" below.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the cephfs Ceph File System label Jan 6, 2022
@huww98 huww98 mentioned this pull request Jan 6, 2022
Merged
14 tasks
lxbsz
lxbsz approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@lxbsz lxbsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lxbsz
Copy link
Member

lxbsz commented Jan 6, 2022

It's worth to create one tracker to backport it.

@vshankar vshankar requested a review from a team January 7, 2022 11:18
@huww98
mds: fix seg fault in expire_recursive
d48a2cf 
Range-based for should not be used when we are altering the container.
Use iterator explicitly instead.

Fixes: https://tracker.ceph.com/issues/53805
Signed-off-by: 胡玮文 <huww98@outlook.com>
@huww98 huww98 force-pushed the fix-expire_recursive-segfault branch from 649d0d4 to d48a2cf Compare January 7, 2022 17:02
@huww98
Copy link
Contributor Author

huww98 commented Jan 7, 2022

It's worth to create one tracker to backport it.

created

@vshankar
Copy link
Contributor

vshankar commented Feb 9, 2022

https://tracker.ceph.com/projects/cephfs/wiki/Master#2022-Feb-09

@vshankar vshankar merged commit e15a529 into ceph:master Feb 9, 2022
@Vicente-Cheng Vicente-Cheng mentioned this pull request Feb 16, 2022
Merged
@huww98 huww98 deleted the fix-expire_recursive-segfault branch April 19, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

@lxbsz lxbsz lxbsz approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa
Projects
None yet
Milestone
No milestone
4 participants
@huww98 @lxbsz @vshankar @batrick