librbd: restore diff-iterate include_parent functionality in fast-diff mode #44496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
…f mode Commit 4429ed4 ("librbd: switch diff iterate API to use new snaps list dispatch methods") removed the recursive execute() call. The new list_snaps method does indeed handle parent diffs internally but it is not used in fast-diff mode. Nothing changed there -- we still need to load the parent object map, calculate parent object_diff_state, etc. Fixes: https://tracker.ceph.com/issues/53787 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
The fast-diff feature wasn't propagated to the clone so these tests were exercising the slow list_snaps path no matter what RBD_FEATURES value was supplied to ceph_test_librbd. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
idryomov
force-pushed
the
wip-diff-iterate-parent-fix
branch
from
2b108d3
to
ceb13d7
Compare
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox