cephadm: check if cephadm is root after cli is parsed #44498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the parsing and processing of the CLI from the logging setup in the cephadm main func. Move logging setup to occur after we've determined that there's a runnable command func. This is preparatory work to allow running `cephadm --help` without being root. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Fixes: https://tracker.ceph.com/issues/53572 Perform a check if cephadm is root after the CLI arguments are parsed but before logging is configured. This allows a user to get help on cephadm without requiring to be root or use sudo, etc. The root check must be done before logging is configured because the logging set up function creates dirs and files in system dirs. Signed-off-by: John Mulligan <jmulligan@redhat.com>
adk3798
approved these changes
Jan 10, 2022
|
jenkins test make check |
|
Unrelated failures:
Not aware of a tracker for this but it has also happened on other runs as well and has no correlation with this change Multiple dead jobs testing ingress, unrelated to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids checking that the command is root until after the cli is parsed so that cli help can be displayed to regular non-root users. I opted not to try and refactor the logging setup call too much, but in the future it may be good to separate the setup of the logging module in python from the environmental setup actions that require root privs.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox