Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: add option to supports fake mounts in mount.ceph #44651

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

nmshelke
Copy link
Contributor

@nmshelke nmshelke commented Jan 19, 2022

Fixes: https://tracker.ceph.com/issues/53903
Signed-off-by: Nikhilkumar Shelke nshelke@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nmshelke nmshelke requested review from vshankar, jtlayton and a team January 19, 2022 07:16
Fixes: https://tracker.ceph.com/issues/53903
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. It would have been nicer to move this to getopt_long instead of hand-parsing options, but it's not a huge problem here. Note that this won't understand the --fake flag though (if /bin/mount passes that through to the helper as-is).

@gregsfortytwo gregsfortytwo added the cephfs Ceph File System label Jan 24, 2022
@vshankar
Copy link
Contributor

Looks fine. It would have been nicer to move this to getopt_long instead of hand-parsing options, but it's not a huge problem here. Note that this won't understand the --fake flag though (if /bin/mount passes that through to the helper as-is).

This would be nice time to move to getopt_long IMO.

Fixes: https://tracker.ceph.com/issues/53903
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
@nmshelke
Copy link
Contributor Author

nmshelke commented Jan 25, 2022

Looks fine. It would have been nicer to move this to getopt_long instead of hand-parsing options, but it's not a huge problem here. Note that this won't understand the --fake flag though (if /bin/mount passes that through to the helper as-is).

This would be nice time to move to getopt_long IMO.

@vshankar @jtlayton Done

Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@vshankar
Copy link
Contributor

vshankar commented Feb 9, 2022

@vshankar vshankar merged commit 047d8fa into ceph:master Feb 9, 2022
@nmshelke nmshelke deleted the fake-mount-53903 branch May 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System
Projects
None yet
6 participants