-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount: add option to supports fake mounts in mount.ceph #44651
Conversation
Fixes: https://tracker.ceph.com/issues/53903 Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
d622b63
to
db2d057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. It would have been nicer to move this to getopt_long instead of hand-parsing options, but it's not a huge problem here. Note that this won't understand the --fake flag though (if /bin/mount passes that through to the helper as-is).
This would be nice time to move to getopt_long IMO. |
Fixes: https://tracker.ceph.com/issues/53903 Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer!
Fixes: https://tracker.ceph.com/issues/53903
Signed-off-by: Nikhilkumar Shelke nshelke@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox