Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octopus: rgw: bucket index list produces incorrect result when non-ascii entries #44858

Closed
wants to merge 1 commit into from
Closed

octopus: rgw: bucket index list produces incorrect result when non-ascii entries #44858

wants to merge 1 commit into from

Conversation

ivancich
Copy link
Member

@ivancich ivancich commented Feb 1, 2022 •
edited

A recent PR that helped address the issue of non-ascii plain entries
didn't cover all the bases, allowing I/O errors to be produced in some
circumstances during a bucket index list (i.e., radosgw-admin bi list ...).

This fixes those issue and does some additional clean-up.

Signed-off-by: J. Eric Ivancich ivancich@redhat.com

Fixes: https://tracker.ceph.com/issues/52010

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added this to the octopus milestone Feb 1, 2022
@ivancich ivancich changed the title rgw: bucket index list produces incorrect result when non-ascii entries octopus: rgw: bucket index list produces incorrect result when non-ascii entries Feb 1, 2022
@ivancich
rgw: bucket index list produces incorrect result when non-ascii entries
d3d8df7 
A recent PR that helped address the issue of non-ascii plain entries
didn't cover all the bases, allowing I/O errors to be produced in some
circumstances during a bucket index list (i.e., `radosgw-admin bi list
...`).

This fixes those issue and does some additional clean-up.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit e714f0d)
@ivancich ivancich force-pushed the octopus-broken-list-plain-entries branch from d65eee4 to d3d8df7 Compare February 1, 2022 21:54
@dvanders dvanders mentioned this pull request Feb 18, 2022
Merged
@dvanders
Copy link
Contributor

@ivancich @cbodley I propose that we close this in favor of #45088

@cbodley cbodley closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbenjamin mattbenjamin Awaiting requested review from mattbenjamin

@cbodley cbodley Awaiting requested review from cbodley

Assignees
No one assigned
Labels
bug-fix needs-qa needs-review rgw
Projects
None yet
Milestone
octopus
3 participants
@ivancich @dvanders @cbodley