quincy: test/bufferlist: ensure rebuild_aligned_size_and_memory() always rebuilds. #44891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y() actually happens.
For the investigation of failures like the following one:
```
[ RUN ] BufferList.rebuild_aligned_size_and_memory
../src/test/bufferlist.cc:1865: Failure
Expected equality of these values:
bl.get_num_buffers()
Which is: 2
1
[ FAILED ] BufferList.rebuild_aligned_size_and_memory (0 ms)
```
The test case assumes the rebuild before the failed clause **always**
happens while `bufferlist::rebuild_aligned_size_and_memory()` skips it
if buffers are already aligned.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 2de5f17)
…ilds. Before the patch the test case was showing an unreliable behaviour dependent on the underlying memory allocator. It was because the bufferlist rebuild can be skipped, resulting in unchanged number of buffers, if all of them begin at aligned addresses. The commit fixes that by allocating a 4 KiB-aligned buffer and offsetting it by a small constant (42) to ensure the memory added to the bufferlist begins at non-4 KiB address. Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com> (cherry picked from commit 88176ac)
|
@neha-ojha @rzarzynski would like to see this merge asap, as the bufferlist failure is blocking merge of other quincy PRs |
rzarzynski
approved these changes
Feb 3, 2022
|
p.s. thanks for the fix Radek <3 |
|
Thanks for the backport, Casey! If there are not objections, I will merge it today, just after the big green button becomes available. It's a unittest fix, so I doubt we need a teuthology run. |
go for it |
idryomov
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/53974
clean cherry-pick required additional commit from #44675
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox