rgw/dbstore: Add dbstore-tests to make check

[soumyakoduri]

Include and run dbstore-tests as part of make check target

Fixes: https://tracker.ceph.com/issues/54193
Signed-off-by: Soumya Koduri skoduri@redhat.com

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[soumyakoduri]

jenkins test make check

[dang]

DBStore tests are failing

[soumyakoduri]

DBStore tests are failing

yes..current master seems to be broken for dbstore (which is fixed as part of #44813).

However the error reported in this jenkins test seems to be related to environment set-up. (https://jenkins.ceph.com/job/ceph-pull-requests/89893/testReport/junit/projectroot.src.rgw.store.dbstore/tests/dbstore_tests/). I am not sure why it complains so. I will try retriggering the test post rebasing to PR#44813

[soumyakoduri]

jenkins test api

[soumyakoduri]

@dang @cbodley .. 'make check' succeeds now. Please review the changes.

Also noticed that with this change the dbstore test binary is no longer generated in $build/bin/ path (in vstart build). Could you please let me know if there is any cmd to run only this particular unittest (on local dev vstart cluster) without having to run entire 'make check'.

[dang]

Unit tests aren't built in the default targets. You can run "make tests" to build the unit tests, but not run them. Then you can run the individual test.

[cbodley]

Also noticed that with this change the dbstore test binary is no longer generated in $build/bin/ path (in vstart build). Could you please let me know if there is any cmd to run only this particular unittest (on local dev vstart cluster) without having to run entire 'make check'.

from the jenkins build log, i do see it under bin/:

[2244/2502] Linking CXX executable bin/unittest_dbstore_tests

[soumyakoduri]

Unit tests aren't built in the default targets. You can run "make tests" to build the unit tests, but not run them. Then you can run the individual test.

Also noticed that with this change the dbstore test binary is no longer generated in $build/bin/ path (in vstart build). Could you please let me know if there is any cmd to run only this particular unittest (on local dev vstart cluster) without having to run entire 'make check'.

from the jenkins build log, i do see it under bin/:

[2244/2502] Linking CXX executable bin/unittest_dbstore_tests

Oh. But it wasn't generated as part of just "ninja vstart" build

[soumyakoduri]

Unit tests aren't built in the default targets. You can run "make tests" to build the unit tests, but not run them. Then you can run the individual test.

okay. Thanks!

[cbodley]

you can also build individual targets with make unittest_dbstore_tests or ninja unittest_dbstore_tests. cmake --build . --target unittest_dbstore_tests works with both

[soumyakoduri]

you can also build individual targets with make unittest_dbstore_tests or ninja unittest_dbstore_tests. cmake --build . --target unittest_dbstore_tests works with both

cool thank you!