octopus: rgw: Use 100-continue in OPA requests to reduce latency #44950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we send a POST request to Open Policy Agent, we send the headers first, wait for TCP ACK from the server, and then send the body. But due to [delayed ACK], the TCP ACK can be delayed by up to 500 ms (but typically 40 ms on Linux), which in this case is huge as OPA typically takes only 1 ms to process a request. This commit adds the ``` Expect: 100-continue ``` header to the `POST` requests sent to OPA, which makes the server reply with ``` HTTP/1.1 100 Continue ``` immediately after receiving the headers, thereby avoiding the 40 ms delay. [delayed ACK]: https://en.wikipedia.org/wiki/TCP_delayed_acknowledgment Fixes: https://tracker.ceph.com/issues/52067 Signed-off-by: Benoît Knecht <bknecht@protonmail.ch> (cherry picked from commit 871d180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/52242
backport of #42685
parent tracker: https://tracker.ceph.com/issues/52067
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh