qa/tasks/cephadm_cases: increase timeouts in test_cli.py #44965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to be failing sometimes but in my testing sometimes these events are happening a few seconds after we hit the timeout. Trying to see if this makes the tests more consistent. No need to mark the test as failed if we report something up in 34 seconds vs 25 especially when cephadm works on a cyclic daemon refresh. Signed-off-by: Adam King <adking@redhat.com>
mgfritch
approved these changes
Feb 10, 2022
| @@ -44,30 +44,30 @@ def test_yaml(self): | |||
|
|
|||
| def test_pause(self): | |||
| self._orch_cmd('pause') | |||
| self.wait_for_health('CEPHADM_PAUSED', 30) | |||
| self.wait_for_health('CEPHADM_PAUSED', 60) | |||
There was a problem hiding this comment.
Maybe this is overkill, but perhaps it would be helpful to have a "constant" for the standard wait period? Something like heath_wait_secs In other cases you can still have non-default values OR do a multiple of the health_wait_secs value...
There was a problem hiding this comment.
you're probably right here, although I didn't see the wait times as sort of connected in any way (it's just intervals like 30 and 60 are natural) so I didn't set anything up. I'm probably going to merge this since the qa run was good and I don't want to have to test it again right now but I'll keep the idea in mind if I look here again.
14 tasks
14 tasks
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be failing sometimes but in my testing
sometimes these events are happening a few seconds after
we hit the timeout. Trying to see if this makes the tests
more consistent. No need to mark the test as failed
if we report something up in 34 seconds vs 25 especially
when cephadm works on a cyclic daemon refresh.
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox