Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/qemu: make sure block-rbd.so is installed #45045

Merged
merged 2 commits into from Feb 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions qa/suites/rbd/singleton/all/qemu-iotests-no-cache.yaml
Expand Up @@ -3,6 +3,11 @@ roles:
- [mon.a, mgr.x, osd.0, osd.1, client.0]
tasks:
- install:
extra_system_packages:
rpm:
- qemu-kvm-block-rbd
deb:
- qemu-block-extra
- ceph:
fs: xfs
conf:
Expand Down
5 changes: 5 additions & 0 deletions qa/suites/rbd/singleton/all/qemu-iotests-writearound.yaml
Expand Up @@ -3,6 +3,11 @@ roles:
- [mon.a, mgr.x, osd.0, osd.1, client.0]
tasks:
- install:
extra_system_packages:
rpm:
- qemu-kvm-block-rbd
deb:
- qemu-block-extra
- ceph:
fs: xfs
conf:
Expand Down
5 changes: 5 additions & 0 deletions qa/suites/rbd/singleton/all/qemu-iotests-writeback.yaml
Expand Up @@ -3,6 +3,11 @@ roles:
- [mon.a, mgr.x, osd.0, osd.1, client.0]
tasks:
- install:
extra_system_packages:
rpm:
- qemu-kvm-block-rbd
deb:
- qemu-block-extra
- ceph:
fs: xfs
conf:
Expand Down
5 changes: 5 additions & 0 deletions qa/suites/rbd/singleton/all/qemu-iotests-writethrough.yaml
Expand Up @@ -3,6 +3,11 @@ roles:
- [mon.a, mgr.x, osd.0, osd.1, client.0]
tasks:
- install:
extra_system_packages:
rpm:
- qemu-kvm-block-rbd
deb:
- qemu-block-extra
- ceph:
fs: xfs
conf:
Expand Down
21 changes: 21 additions & 0 deletions qa/tasks/qemu.py
Expand Up @@ -14,6 +14,7 @@
from teuthology import misc as teuthology
from teuthology.config import config as teuth_config
from teuthology.orchestra import run
from teuthology.packaging import install_package, remove_package

log = logging.getLogger(__name__)

Expand Down Expand Up @@ -158,6 +159,25 @@ def create_dirs(ctx, config):
]
)

@contextlib.contextmanager
def install_block_rbd_driver(ctx, config):
"""
Make sure qemu rbd block driver (block-rbd.so) is installed
"""
for client, client_config in config.items():
(remote,) = ctx.cluster.only(client).remotes.keys()
if remote.os.package_type == 'rpm':
block_rbd_pkg = 'qemu-kvm-block-rbd'
else:
block_rbd_pkg = 'qemu-block-extra'
install_package(block_rbd_pkg, remote)
try:
yield
finally:
for client, client_config in config.items():
(remote,) = ctx.cluster.only(client).remotes.keys()
remove_package(block_rbd_pkg, remote)

@contextlib.contextmanager
def generate_iso(ctx, config):
"""Execute system commands to generate iso"""
Expand Down Expand Up @@ -660,6 +680,7 @@ def task(ctx, config):
create_images(ctx=ctx, config=config, managers=managers)
managers.extend([
lambda: create_dirs(ctx=ctx, config=config),
lambda: install_block_rbd_driver(ctx=ctx, config=config),
lambda: generate_iso(ctx=ctx, config=config),
lambda: download_image(ctx=ctx, config=config),
])
Expand Down