mds: add long snap name flag in LeaseStat for fscrypt #45208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajarr
reviewed
Mar 1, 2022
lxbsz
force-pushed
the
snapshotlongname_flag
branch
from
76c0269
to
0d5cc90
Compare
|
jenkins retest this please |
ajarr
approved these changes
Mar 3, 2022
For the long snapshot names, which are from the parent CInodes,
the format will be "_${ENCRYPTED-NAME}_${PARENT-INO}". In kclient
side we need to base64 decode it to human readable format of
"_${DENCRYPTED-NAME}_${PARENT-INO}" if the encrypt key exists. So
we need to know whether the current snapshot name is a long snap
name.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
lxbsz
force-pushed
the
snapshotlongname_flag
branch
from
0d5cc90
to
45644db
Compare
|
jenkins test make check |
|
Will close it since the snapshot names can not start with an underscore ('_'), as these names are reserved for internal usage. Please see #45312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the long snapshot names, which are from the parent CInodes,
the format will be "${ENCRYPTED-NAME}${PARENT-INO}". In kclient
side we need to base64 decode it to human readable format of
"${DENCRYPTED-NAME}${PARENT-INO}" if the encrypt key exists. So
we need to know whether the current snapshot name is a long snap
name.
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox