Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: adding HostSpec validation #45275

Merged
merged 1 commit into from Mar 30, 2022
Merged

Conversation

rkachach
Copy link
Contributor

@rkachach rkachach commented Mar 7, 2022

Fixes: https://tracker.ceph.com/issues/54342

Signed-off-by: Redouane Kachach rkachach@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@rkachach
Copy link
Contributor Author

jenkins test api

@rkachach
Copy link
Contributor Author

jenkins retest this please

src/pybind/mgr/orchestrator/module.py Outdated Show resolved Hide resolved
@rkachach rkachach changed the title mgr/cephadm: adding hostname validation mgr/cephadm: adding HostSpec validation Mar 24, 2022
Fixes: https://tracker.ceph.com/issues/54342

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach
Copy link
Contributor Author

Moving back the validation check to cephadm as the issue seems to be related with sub interpreters not propagating correctly the Exception.

@adk3798 adk3798 merged commit 5b49c10 into ceph:master Mar 30, 2022
@adk3798 adk3798 mentioned this pull request Mar 30, 2022
14 tasks
@adk3798 adk3798 mentioned this pull request Apr 27, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants