New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/cephadm: adding HostSpec validation #45275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins test api |
jenkins retest this please |
rkachach
force-pushed
the
fix_issue_54342
branch
from
March 11, 2022 12:03
5080299
to
5902062
Compare
adk3798
approved these changes
Mar 22, 2022
adk3798
requested changes
Mar 24, 2022
rkachach
changed the title
mgr/cephadm: adding hostname validation
mgr/cephadm: adding HostSpec validation
Mar 24, 2022
Fixes: https://tracker.ceph.com/issues/54342 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
rkachach
force-pushed
the
fix_issue_54342
branch
from
March 24, 2022 17:41
5902062
to
15ba147
Compare
Moving back the validation check to cephadm as the issue seems to be related with sub interpreters not propagating correctly the Exception. |
adk3798
approved these changes
Mar 26, 2022
Failures: |
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/54342
Signed-off-by: Redouane Kachach rkachach@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows