New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephadm: respect --skip-firewalld flag #45399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits, otherwise lgtm!
src/cephadm/tests/test_cephadm.py
Outdated
@mock.patch('cephadm.logger') | ||
@mock.patch('os.fchown') | ||
def test_skip_firewalld(self, fchown, logger): | ||
# test --skip-firewalld actually skips changing firewall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a docstring comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is what's there now what you meant?
1 Dead job due to failing to power on a machine |
jenkins test make check |
jenkins test api |
Fixes: https://tracker.ceph.com/issues/54137 Signed-off-by: Adam King <adking@redhat.com>
2 Failures caused by wrong error code from host add command due to another PR included in the run |
Fixes: https://tracker.ceph.com/issues/54137
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows