Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Language dropdown box is partly hidden on login page #45429

Merged
merged 1 commit into from
Mar 23, 2022
Merged

mgr/dashboard: Language dropdown box is partly hidden on login page #45429

merged 1 commit into from
Mar 23, 2022

Conversation

votdev
Copy link
Member

@votdev votdev commented Mar 16, 2022 •
edited

When clicking on the language dropdown combobox on the login page, the menu is partly hidden because it is partly rendered out of the visible area. Additionally the scrollbars are displayed.

Before:
screenshot

After:
Bildschirmfoto vom 2022-03-16 16-54-33

Fixes: https://tracker.ceph.com/issues/54591

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@votdev
mgr/dashboard: Language dropdown box is partly hidden on login page
f3e4c9e 
When clicking on the language dropdown combobox on the login page, the menu is partly hidden because it is partly rendered out of the visible area. Additionally the scrollbars are displayed.

Fixes: https://tracker.ceph.com/issues/54591
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev requested a review from a team as a code owner March 16, 2022 15:56
@votdev votdev added this to In progress in Dashboard via automation Mar 16, 2022
@votdev votdev requested review from sunilangadi2 and nizamial09 and removed request for a team March 16, 2022 15:56
@votdev votdev moved this from In progress to Review in progress in Dashboard Mar 16, 2022
@votdev
Copy link
Member Author

votdev commented Mar 17, 2022

jenkins test dashboard

1 similar comment
@votdev
Copy link
Member Author

votdev commented Mar 21, 2022

jenkins test dashboard

@votdev votdev requested a review from a team March 22, 2022 08:51
@votdev
Copy link
Member Author

votdev commented Mar 22, 2022

jenkins test dashboard

@votdev
Copy link
Member Author

votdev commented Mar 22, 2022 •
edited

Is there any chance to get rid of those unit tests that are using this proprietary applitools tool? Why removing:

  • If tests fail, the reason can not be seen by every Dashboard developer. An account is required
  • These tests always fail IMO
  • Without an account it is impossible to fix the PR
  • An OSS project like Ceph and proprietary tools do not match

If we stay on these tools, someone with an account at applitools.com must fix the PR issues.

@votdev votdev requested a review from epuertat March 22, 2022 09:08
@epuertat
Copy link
Member

Is there any chance to get rid of those unit tests that are using this proprietary applitools tool? Why removing:

Sure. What visual regression testing tool you would suggest instead?

  • If tests fail, the reason can not be seen by every Dashboard developer. An account is required
  • Without an account it is impossible to fix the PR

I just sent you an invite to the Applitools web.

  • These tests always fail IMO

These failures are due to breaking changes in browsers (Chrome 99.0 and Firefox 98.0) and they need to be manually inspected and approved.

  • An OSS project like Ceph and proprietary tools do not match

You're writing this in Github, which is a propietary tool that requires you to create an account. Same applies for Transifex, Cypress, etc.

If we stay on these tools, someone with an account at applitools.com must fix the PR issues.

That's what's happening, but we don't have a 24/7 team to fix test issues.

@epuertat
Copy link
Member

jenkins test dashboard

Dashboard automation moved this from Review in progress to Reviewer approved Mar 22, 2022
@votdev
Copy link
Member Author

votdev commented Mar 23, 2022

jenkins test dashboard

@votdev
Copy link
Member Author

votdev commented Mar 23, 2022 •
edited

Is there any chance to get rid of those unit tests that are using this proprietary applitools tool? Why removing:

Sure. What visual regression testing tool you would suggest instead?

I have none to suggest. But i'm asking myself whether they are really needed. According to my feeling they make more troubles than they help.

  • If tests fail, the reason can not be seen by every Dashboard developer. An account is required
  • Without an account it is impossible to fix the PR

I just sent you an invite to the Applitools web.

Thanks

  • These tests always fail IMO

These failures are due to breaking changes in browsers (Chrome 99.0 and Firefox 98.0) and they need to be manually inspected and approved.

  • An OSS project like Ceph and proprietary tools do not match

You're writing this in Github, which is a propietary tool that requires you to create an account. Same applies for Transifex, Cypress, etc.

I think there is a difference. It's my own choice as a contributor to create an GitHub or Transifex account to participate on the project. But i am forced to create an account at Applitools if there are problems with a PR, otherwise i'm not able to check what happens and the PR will not get merged. The sad thing is when if comes out that the code of the PR is not responsible for the failure of the Applitools tests. It is really intransparent process. IMO a PR should be merged even if there are Applitools test failures.

If we stay on these tools, someone with an account at applitools.com must fix the PR issues.

That's what's happening, but we don't have a 24/7 team to fix test issues.

As said above, in this case Applitools failures should not block PRs from getting merged.

@votdev
Copy link
Member Author

votdev commented Mar 23, 2022

jenkins test dashboard

@epuertat
Copy link
Member

@votdev applitools tests are not blocking any merging (not "required" by Github), we just need to ensure that the failures are unrelated.

@epuertat epuertat merged commit 9aa5c79 into ceph:master Mar 23, 2022
Dashboard automation moved this from Reviewer approved to Done Mar 23, 2022
@votdev votdev deleted the issue_54591_language_dropdown branch March 23, 2022 15:01
This was referenced Mar 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epuertat epuertat epuertat approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@sunilangadi2 sunilangadi2 Awaiting requested review from sunilangadi2 sunilangadi2 was automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
bug-fix dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
3 participants
@votdev @epuertat @nizamial09