octopus: radosgw-admin: 'sync status' is not behind if there are no mdlog entries #45443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if remote mdlogs are trimmed prematurely, sync status will report that it's behind the remote's max-marker even if there are no mdlog entries to sync for each behind shard, we fetch the next mdlog entry from the remote. if we get an empty listing, remove that shard from behind_shards. this logic now has to run before we print "behind shards:" so that empty shards aren't listed Fixes: https://tracker.ceph.com/issues/52091 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 14d43f7)
cbodley
approved these changes
May 9, 2022
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/52108
backport of #42708
parent tracker: https://tracker.ceph.com/issues/52091
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh