pacific: radosgw-admin: 'reshard list' doesn't log ENOENT errors #45451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check |
cfsnyder
force-pushed
the
wip-52958-pacific
branch
from
2d65a1f
to
87e1d5d
Compare
cbodley
previously requested changes
Oct 5, 2022
src/rgw/rgw_reshard.cc
Outdated
Comment on lines
897
to
901
| lderr(store->ctx) << "ERROR: access denied to pool " << store->svc()->zone->get_zone_params().reshard_pool | ||
| << ". Fix the pool access permissions of your client" << dendl; | ||
| } else if (ret < 0) { | ||
| lderr(store->ctx) << "ERROR: failed to list reshard log entries, oid=" | ||
| << logshard_oid << " marker=" << marker << " " << cpp_strerror(ret) << dendl; |
There was a problem hiding this comment.
ctx is a member function, so this should be store->ctx() like the code it replaces
build log:
src/rgw/rgw_reshard.cc: In member function ‘int RGWReshard::list(int, std::__cxx11::string&, uint32_t, std::__cxx11::list<cls_rgw_reshard_entry>&, bool*)’:
src/common/dout.h:159:8: error: invalid use of non-static member function ‘virtual ceph::common::CephContext* rgw::sal::RGWRadosStore::ctx()’
}(cct); \
^
src/common/dout.h:177:20: note: in expansion of macro ‘dout_impl’
#define lderr(cct) dout_impl(cct, ceph_subsys_, -1) dout_prefix
^~~~~~~~~
src/rgw/rgw_reshard.cc:904:5: note: in expansion of macro ‘lderr’
lderr(store->ctx) << "ERROR: access denied to pool " << store->svc()->zone->get_zone_params().reshard_pool
^~~~~
In file included from src/rgw/rgw_reshard.cc:11:
src/rgw/rgw_sal_rados.h:328:26: note: declared here
virtual CephContext *ctx(void) { return rados->ctx(); }
^~~
ENOENT errors are expected, especially in fresh clusters, before we've written any entries to the reshard list shards. avoid logging these non-fatal ERROR messages: > -1 ERROR: failed to list reshard log entries, oid=reshard.0000000000 marker= (2) No such file or directory Fixes: https://tracker.ceph.com/issues/52873 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 952c7c8) Conflicts: src/rgw/rgw_reshard.cc Cherry-pick notes: - pacific using lderr vs ldpp_dout
cfsnyder
force-pushed
the
wip-52958-pacific
branch
from
87e1d5d
to
d97a02e
Compare
cbodley
approved these changes
Dec 5, 2022
|
jenkins test make check |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
jenkins test make check |
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/52958
backport of #43488
parent tracker: https://tracker.ceph.com/issues/52873
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh