cephfs-top: Multiple filesystem support

[neesingh-rh]

Cephfs-top command was only showing metrics for one filesystem due to absence of metadata in perf_stats command.

Fixes: https://tracker.ceph.com/issues/50470
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[neesingh-rh]

Adding snaps:
1.perf_stats:

2.cephfs-top:

[lxbsz]

Will it make sense to show the clients from different filesystems in dedicated windows ?

[neesingh-rh]

Will it make sense to show the clients from different filesystems in dedicated windows ?

I guess its in respect with cephfs-top window,right?How about adding one column with file system name?

[lxbsz]

Will it make sense to show the clients from different filesystems in dedicated windows ?

I guess its in respect with cephfs-top window,right?

Yeah. It will be split into several virtual windows in the terminal.

How about adding one column with file system name?

Yeah, name or the fscid, but I am afraid in product use case the name or fscid will be very long(?), so add a new column will make the couldn't display it all in one line ?

[neesingh-rh]

Will it make sense to show the clients from different filesystems in dedicated windows ?

I guess its in respect with cephfs-top window,right?

Yeah. It will be split into several virtual windows in the terminal.

How about adding one column with file system name?

Yeah, name or the fscid, but I am afraid in product use case the name or fscid will be very long(?), so add a new column will make the couldn't display it all in one line ?

Regarding separate windows for filesystems, I think we can have it in two ways:

1. Add a method in cephfs-top which fetches fs_name and client counts or other details as required.
2. We will have to change the structure of perf_stats o/p, so that we can directly fetch the required info from there.Structure will be something like this:
   {version:”value”,....,client_metadata:{fs1:{client1.id:{“IP”,....,valid_metrics},client2.id:{“IP”,....,valid_metrics}},fs2:{client1.id:{“IP”,....,valid_metrics}},global_metrics:{...},.....}
   Any suggestions,which one will be better?Or some other better way of doing it?

[vshankar]

Will it make sense to show the clients from different filesystems in dedicated windows ?

Nice idea. @neesingh-rh Let's do this as a separate PR.

[vshankar]

@neesingh-rh Please add tests in `qa/tasks/cephfs/test_mds_metrics.py' to verify that client metrics and metadata are updated as expected.

[lxbsz]

Will it make sense to show the clients from different filesystems in dedicated windows ?

Nice idea. @neesingh-rh Let's do this as a separate PR.

Certainly.

[lxbsz]

Yeah, name or the fscid, but I am afraid in product use case the name or fscid will be very long(?), so add a new column will make the couldn't display it all in one line ?

Regarding separate windows for filesystems, I think we can have it in two ways:

1. Add a method in cephfs-top which fetches fs_name and client counts or other details as required.
2. We will have to change the structure of perf_stats o/p, so that we can directly fetch the required info from there.Structure will be something like this:
   {version:”value”,....,client_metadata:{fs1:{client1.id:{“IP”,....,valid_metrics},client2.id:{“IP”,....,valid_metrics}},fs2:{client1.id:{“IP”,....,valid_metrics}},global_metrics:{...},.....}
   Any suggestions,which one will be better?Or some other better way of doing it?

The first one sounds simpler and easier to do ?

[neesingh-rh]

Yeah, name or the fscid, but I am afraid in product use case the name or fscid will be very long(?), so add a new column will make the couldn't display it all in one line ?

Regarding separate windows for filesystems, I think we can have it in two ways:

1. Add a method in cephfs-top which fetches fs_name and client counts or other details as required.
2. We will have to change the structure of perf_stats o/p, so that we can directly fetch the required info from there.Structure will be something like this:
   {version:”value”,....,client_metadata:{fs1:{client1.id:{“IP”,....,valid_metrics},client2.id:{“IP”,....,valid_metrics}},fs2:{client1.id:{“IP”,....,valid_metrics}},global_metrics:{...},.....}
   Any suggestions,which one will be better?Or some other better way of doing it?

The first one sounds simpler and easier to do ?

Yes.

[neesingh-rh]

jenkins test make check

[gregsfortytwo]

@vshankar you had a comment which looks like it is resolved, is there something blocking this from an integration branch? :)

[vshankar]

@vshankar you had a comment which looks like it is resolved, is there something blocking this from an integration branch? :)

It's in my branch for test run over weekend, just that I didn't tag it.

Tagging it now..

[vshankar]

https://tracker.ceph.com/projects/cephfs/wiki/Master#2022-May-04