octopus: librbd: readv/writev fix iovecs length computation overflow #45560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iovec have unsigned length (size_t) and before this patch the total length was computed by adding iovec's length to a signed length variable (ssize_t). While the code checked if the resulting length was negative on overflow, the case where length is positive after overflow was not checked. This patch fixes the overflow check by changing length to unsigned size_t. Additionally, this patch fixes the case where some iovecs have been added to the bufferlist and the aio completion has been blocked, but adding an additional iovec fails because of overflow. This leads to the UserBufferDeleter trying to unblock the completion on destruction of the bufferlist but asserting because the completion was never armed. We avoid this by first computing the total length and checking for overflows and iovcnt before adding them to the bufferlist. Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch> (cherry picked from commit e50405e) Conflicts: src/librbd/librbd.cc [ commit b12b8c4 ("librbd: switch to new api::Io dispatch helper methods") not in octopus ]
|
make check |
chrisphoffman
approved these changes
Mar 22, 2022
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #45353 to octopus.