ceph-mixin: rewrite promql queries to multiline

[MrFreezeex]

Fixes: https://tracker.ceph.com/issues/55005
Signed-off-by: Arthur Outhenin-Chalandre arthur.outhenin-chalandre@cern.ch

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[MrFreezeex]

As promised in #44059 here is a rewrite of "long" (long = subjective appreciation) promql queries. I don't have any automatic tools that check and reformat those, so it's by hand unfortunately. Feel free to comment on the style that I chose, no guarantee that it's fully consistent everywhere as there is quite some code here 😅.

Also there shouldn't be any change to the queries itself but as everything is hand made I could have made some mistakes...

[github-actions]

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

[MrFreezeex]

Not sure why the ceph dashboards e2e test are failing, this was really painful to rebase though so I hope I didn't break anything...

[epuertat]

Not sure why the ceph dashboards e2e test are failing, this was really painful to rebase though so I hope I didn't break anything...

Thanks a lot! This is a really thorough work, @MrFreezeex ! We'll do our best not to merge anything that forces you to rebase this again 😅

[epuertat]

BTW, the failures might be unrelated. Let's see.

[MrFreezeex]

jenkins test dashboard

[MrFreezeex]

Now the CI is happy :D. Note that I have other improvments/cleanup to do once this is merged.

[epuertat]

Merged! Thanks a lot @MrFreezeex for your clean up here!

[MrFreezeex]

Merged! Thanks a lot @MrFreezeex for your clean up here!

No worries, there are follow up coming as well on other stuff :p

[epuertat]

Great!

In case you're looking for more stuff to tackle: one area we want to harden further is Grafana dashboards testing. For that purpose, besides the promtool tests, @nizamial09 recently introduced BDD e2e/integration testing for Grafana. Those "just" check the "hosts" and the RGW Grafana dashboards, so it'd be great to extend it to other Grafana dashboards too, and perhaps measure coverage, etc.